fixed #113

apache · Mar 24, 2018 · fa54e2a · fa54e2a
1 parent bc18bdf
commit fa54e2a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/bin/start-waterdrop.sh b/bin/start-waterdrop.sh
@@ -1,7 +1,6 @@
 #!/bin/bash
 
 # TODO: compress plugins/ dir before start-waterdrop.sh
-# TODO: -t 参数好使吗？
 
 # copy command line arguments
 CMD_ARGUMENTS=$@

diff --git a/waterdrop-core/src/main/scala/io/github/interestinglab/waterdrop/Waterdrop.scala b/waterdrop-core/src/main/scala/io/github/interestinglab/waterdrop/Waterdrop.scala
@@ -37,13 +37,12 @@ object Waterdrop extends Logging {
 
         cmdArgs.testConfig match {
           case true => {
-            new ConfigBuilder(cmdArgs.configFile)
+            new ConfigBuilder(configFilePath).checkConfig
             println("config OK !")
-            // TODO: check config
           }
           case false => {
 
-            entrypoint(cmdArgs.configFile)
+            entrypoint(configFilePath)
           }
         }
       }

diff --git a/waterdrop-core/src/main/scala/io/github/interestinglab/waterdrop/config/ConfigBuilder.scala b/waterdrop-core/src/main/scala/io/github/interestinglab/waterdrop/config/ConfigBuilder.scala
@@ -38,6 +38,16 @@ class ConfigBuilder(configFile: String) {
     parsedConfig
   }
 
+  /**
+   * check if config is valid.
+   * */
+  def checkConfig: Unit = {
+    val sparkConfig = this.getSparkConfigs
+    val inputs = this.createInputs
+    val outputs = this.createOutputs
+    val filters = this.createFilters
+  }
+
   def getSparkConfigs: Config = {
     config.getConfig("spark")
   }