Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Core] Support config variable substitution with default value #7535

Closed
2 of 3 tasks
Hisoka-X opened this issue Aug 30, 2024 · 4 comments · Fixed by #7562
Closed
2 of 3 tasks

[Feature][Core] Support config variable substitution with default value #7535

Hisoka-X opened this issue Aug 30, 2024 · 4 comments · Fixed by #7562
Assignees
Labels

Comments

@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 30, 2024

Search before asking

  • I had searched in the feature and found no similar feature requirement.

Description

We had supported default value with el expression feature in sink-options-placeholders.
eg:
${table_name:default_my_table}

We should support default value with el expression in all config place too. Including env, source, transform, sink.
It's a sub feature of config-variable-substitution. So the el expression with default value will be replaced with user configure value when use shell script with -i.

The flow diagram:
image

Usage Scenario

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@zhangshenghang
Copy link
Member

Can be assigned to me ,thks

@Hisoka-X
Copy link
Member Author

I added a flow diagram cc @zhangshenghang @arshadmohammad

@zhangshenghang
Copy link
Member

I added a flow diagram cc @zhangshenghang @arshadmohammad

@Hisoka-X I have a general understanding of the overall idea. thks

@arshadmohammad
Copy link
Collaborator

Design and approach looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants