Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Core] Config variables update doc and add test case #7709

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

zhangshenghang
Copy link
Member

Purpose of this pull request

1.update doc
2.add test case

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added document core SeaTunnel core module labels Sep 21, 2024
@zhangshenghang
Copy link
Member Author

@Hisoka-X

@Hisoka-X
Copy link
Member

Please fix ci.

@Hisoka-X Hisoka-X changed the title [improve][core] Config variables update doc and add test case [Improve][Core] Config variables update doc and add test case Sep 24, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zhangshenghang

@wuchunfu wuchunfu merged commit ac1e3ec into apache:dev Sep 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants