[Imporve][Connector-V2] Imporve iceberg source connector #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
force-pushed
the
fix-iceberg-source
branch
2 times, most recently
from
7c46b58 to
e0ffe4e
Compare
hailin0
changed the title
|
@ashulin PTAL |
hailin0
force-pushed
the
fix-iceberg-source
branch
from
e0ffe4e to
d38ddb7
Compare
ashulin
reviewed
Sep 24, 2022
...he/seatunnel/connectors/seatunnel/iceberg/source/enumerator/IcebergBatchSplitEnumerator.java
Show resolved
Hide resolved
hailin0
force-pushed
the
fix-iceberg-source
branch
2 times, most recently
from
83ff631 to
190f12e
Compare
EricJoy2048
reviewed
Sep 28, 2022
...e/seatunnel/connectors/seatunnel/iceberg/source/enumerator/IcebergStreamSplitEnumerator.java
Outdated
Show resolved
Hide resolved
hailin0
force-pushed
the
fix-iceberg-source
branch
from
190f12e to
fbdee90
Compare
EricJoy2048
reviewed
Nov 3, 2022
hailin0
force-pushed
the
fix-iceberg-source
branch
from
fbdee90 to
66d61ea
Compare
hailin0
force-pushed
the
fix-iceberg-source
branch
from
0e1c5bd to
ec38fd0
Compare
hailin0
force-pushed
the
fix-iceberg-source
branch
from
ec38fd0 to
95a0bfa
Compare
hailin0
force-pushed
the
fix-iceberg-source
branch
from
95a0bfa to
ce4c5dd
Compare
hailin0
force-pushed
the
fix-iceberg-source
branch
2 times, most recently
from
901cb4d to
3b219cf
Compare
4 tasks
hailin0
force-pushed
the
fix-iceberg-source
branch
2 times, most recently
from
47a5814 to
cce8cbb
Compare
CalvinKirs
reviewed
Jan 17, 2023
| @@ -124,6 +126,7 @@ public void testIcebergSource(TestContainer container) throws IOException, Inter | |||
| } | |||
|
|
|||
| private void initializeIcebergTable() { | |||
| FileUtil.fullyDelete(new File(CATALOG_DIR)); | |||
There was a problem hiding this comment.
Would this be a problem if it wasn't completely deleted?
There was a problem hiding this comment.
Test cases can interfere with each other
EricJoy2048
approved these changes
Apr 1, 2023
EricJoy2048
requested changes
Apr 1, 2023
hailin0
force-pushed
the
fix-iceberg-source
branch
from
cce8cbb to
06071cd
Compare
* Lock output row and update offset in pollNext method to support at-least-once * Add `synchronized` to IcebergStreamSplitEnumerator#run method to avoid update conflicts with readers access `handleSplitRequest` * Fix duplicate read splits when batch job state restore * Fix assign split owner(negative number)
hailin0
force-pushed
the
fix-iceberg-source
branch
from
06071cd to
9ac1b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
synchronizedto IcebergStreamSplitEnumerator#run method to avoid update conflicts with readers accesshandleSplitRequestCheck list
New License Guide