-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Clickhouse-V2] Clickhouse Support Geo type #3141
[Improve][Clickhouse-V2] Clickhouse Support Geo type #3141
Conversation
Maybe we need to change the version of clickhouse-jdbc in the future. ClickHouse/clickhouse-java#1112 |
Please use e2e to test these type. |
Point and Ring data types passed the e2e test. Polygon and MultiPolygon cannot be used temporarily because of a bug in clickhouse jdbc. Please track ClickHouse/clickhouse-java#1112 |
Like this https://github.com/apache/incubator-seatunnel/pull/3047/files#diff-74e1e7a8b81b6f0f364b14de8bf7f0957bcea7d13f1ce23c61be650844fc2ecd , you should turn on clickhouse e2e test. |
…o_type' into clickhouse_sink_support_write_geo_type
@Hisoka-X PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the improve to Clickhouse Connector doc and add the changed log
reference https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/source/Redis.md#next-version
all right |
#3067 |
Yes, add it together. |
all right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this pull request
Clickhouse Sink Support write Geo type #3101
Clickhouse Source also Support Geo type.
Check list
New License Guide