[Improve][Connector-V2][ElasticSearch] Improve es bulk sink retriable mechanism #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricJoy2048
reviewed
Oct 21, 2022
| public class RetryUtils { | ||
| private static final Logger LOG = LoggerFactory.getLogger(RetryUtils.class); |
There was a problem hiding this comment.
| return null; | ||
| }, retryMaterial); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("ElasticSearch execute batch statement error", e); |
There was a problem hiding this comment.
Please use SeaTunnelException and we have an issue to discuss the unified Exception define. If you interested in it, you can see #3045.
|
Please resolve ci problem, thanks. |
harveyyue
force-pushed
the
dev-es-2
branch
3 times, most recently
from
c7e2dd8 to
2ec05be
Compare
Hisoka-X
reviewed
Nov 19, 2022
| /** | ||
| * An arbitrary absolute maximum practical retry time. | ||
| */ | ||
| public static final long MAX_RETRY_TIME_MS = TimeUnit.HOURS.toMillis(1); |
There was a problem hiding this comment.
The max retry is 1 hours, it's to long. 1 minutes will be better.
|
The other code is fine. |
harveyyue
added a commit
to harveyyue/seatunnel
that referenced
this pull request
Nov 21, 2022
Hisoka-X
added
core
EricJoy2048
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These code change as bleow:
computeRetryWaitTimeMillisto compute the wait timeretryWithExceptionPurpose of this pull request
Check list
New License Guide