[Improve][Connector-V2-kafka] Support setting read starting offset or time at startup config #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please refer to Coding Guide and change your pull request titile. Thx. |
Carl-Zhou-CN
changed the title
ok |
|
@Hisoka-X @TyrantLucifer Please help to review |
Hisoka-X
reviewed
Oct 26, 2022
| Map<TopicPartition, ListOffsetsResult.ListOffsetsResultInfo> listOffsets = | ||
| getKafkaPartitionLatestOffset(splits.stream().map(KafkaSourceSplit::getTopicPartition).collect(Collectors.toList())); | ||
| Map<TopicPartition, Long> listOffsets = | ||
| listOffsets(splits.stream().map(KafkaSourceSplit::getTopicPartition).collect(Collectors.toList()), OffsetSpec.earliest()); |
There was a problem hiding this comment.
Why use OffsetSpec.earliest() not latest?
There was a problem hiding this comment.
Sorry, it was my mistake. I should have used latest
There was a problem hiding this comment.
Maybe you should add some test case.
There was a problem hiding this comment.
Ok, I will add e2e tests later
added 3 commits
October 31, 2022 19:03
Carl-Zhou-CN
force-pushed
the
isses-2959
branch
from
739482e to
a81b6dd
Compare
… time at startup config
Carl-Zhou-CN
force-pushed
the
isses-2959
branch
from
a81b6dd to
0fc7bf4
Compare
added 2 commits
November 1, 2022 09:00
… time at startup config
… time at startup config
EricJoy2048
approved these changes
Nov 8, 2022
| info-2 = 10 | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Please add changed log reference https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/source/Redis.md#next-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide
close #2959