[Bug][Core] Fix Change SeaTunnel Logo Print Error in some jdk version #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
reviewed
Oct 22, 2022
| @@ -96,7 +95,8 @@ protected final void close(List<? extends Plugin<E>>... plugins) { | |||
| protected void showAsciiLogo() { | |||
| String printAsciiLogo = System.getenv("SEATUNNEL_PRINT_ASCII_LOGO"); | |||
| if ("true".equalsIgnoreCase(printAsciiLogo)) { | |||
| AsciiArtUtils.printAsciiArt(Constants.LOGO); | |||
There was a problem hiding this comment.
Remove unused code?
https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/core/base/utils/AsciiArtUtils.java
https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/AsciiArtUtils.java
There was a problem hiding this comment.
ok ,that sounds good;
|
Please refer to Coding Guide and change your pull request titile. Thx. |
john8628
changed the title
EricJoy2048
changed the title
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Oct 26, 2022
…apache#3160) * [Bug][Core] Fix Change SeaTunnel Logo Print Error in some jdk version * [Improve][Core] remove unuse class
Carl-Zhou-CN
pushed a commit
to Carl-Zhou-CN/incubator-seatunnel
that referenced
this pull request
Oct 27, 2022
…apache#3160) * [Bug][Core] Fix Change SeaTunnel Logo Print Error in some jdk version * [Improve][Core] remove unuse class
Carl-Zhou-CN
pushed a commit
to Carl-Zhou-CN/incubator-seatunnel
that referenced
this pull request
Oct 31, 2022
…apache#3160) * [Bug][Core] Fix Change SeaTunnel Logo Print Error in some jdk version * [Improve][Core] remove unuse class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
#3153
Check list
New License Guide