[Improve][CI] Improve ci and remove build task and only api or engine changed need run license check #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinKirs
reviewed
Oct 26, 2022
Comment on lines
+108
to
+128
| filters: | | ||
| cv2: | ||
| - "seatunnel-connectors-v2/**" | ||
| cv2-flink-e2e: | ||
| - "seatunnel-e2e/seatunnel-flink-connector-v2-e2e/**" | ||
| cv2-spark-e2e: | ||
| - "seatunnel-e2e/seatunnel-spark-connector-v2-e2e/**" | ||
| cv2-e2e: | ||
| - "seatunnel-e2e/seatunnel-connector-v2-e2e/**" | ||
| api: | ||
| - "seatunnel-api" | ||
| - "seatunnel-apis" | ||
| - "seatunnel-common" | ||
| - "seatunnel-config" | ||
| - "seatunnel-connectors" | ||
| - "seatunnel-core" | ||
| - "seatunnel-dist" | ||
| - "seatunnel-e2e/seatunnel-e2e-common" | ||
| - "seatunnel-formats" | ||
| - "seatunnel-plugin-discovery" | ||
| - "seatunnel-transforms" |
There was a problem hiding this comment.
We just need to determine if he is in the e2e or connectors or other module range, and only execute if he is not. Is this possible to do? Otherwise we would still need to maintain the script, and I would prefer that this be a stable change.
There was a problem hiding this comment.
We just need to determine if he is in the
e2eorconnectorsor other module range, and only execute if he is not. Is this possible to do? Otherwise we would still need to maintain the script, and I would prefer that this be a stable change.
No, it's difficult. Because without api judge we can not know whether api modules be updated when connector and e2e modules been updated too.
CalvinKirs
approved these changes
Oct 26, 2022
Carl-Zhou-CN
pushed a commit
to Carl-Zhou-CN/incubator-seatunnel
that referenced
this pull request
Oct 27, 2022
… changed need run license check (apache#3194) * improve ci and only build by the update modules * remove no use outputs * improve ci and remove build test and connector update will not check license
Carl-Zhou-CN
pushed a commit
to Carl-Zhou-CN/incubator-seatunnel
that referenced
this pull request
Oct 31, 2022
… changed need run license check (apache#3194) * improve ci and only build by the update modules * remove no use outputs * improve ci and remove build test and connector update will not check license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildtask.codeqltask trigger byscheduleapiorenginechanged we will runlicense checktask.