[Feature][Connector-V2-e2e][LocalFile] Add local file connector e2e #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
reviewed
Oct 28, 2022
Comment on lines
33
to
39
| Container.ExecResult textResult = container.executeJob("/text/fake_to_local_file_text.conf"); | ||
| Assertions.assertEquals(0, textResult.getExitCode()); | ||
| Container.ExecResult jsonResult = container.executeJob("/json/fake_to_local_file_json.conf"); | ||
| Assertions.assertEquals(0, jsonResult.getExitCode()); | ||
| Container.ExecResult orcResult = container.executeJob("/orc/fake_to_local_file_orc.conf"); | ||
| Assertions.assertEquals(0, orcResult.getExitCode()); | ||
| Container.ExecResult parquetResult = container.executeJob("/parquet/fake_to_local_file_parquet.conf"); |
There was a problem hiding this comment.
Add local_file_xxx_to_assert.conf validate row count & field types?
Or
you can read sink data check rows & fields
There was a problem hiding this comment.
Yup, this pull request is not completed. It's also a draft pr.
TyrantLucifer
force-pushed
the
local-file-e2e
branch
from
d0fff1a to
2837a44
Compare
TyrantLucifer
force-pushed
the
local-file-e2e
branch
from
15c989e to
409fdf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #3159
Check list
New License Guide