[Feature][Connector-V2][My Hours]Add My Hours Source Connector #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into myhours � Conflicts: � docs/en/Connector-v2-release-state.md
EricJoy2048
reviewed
Oct 29, 2022
|
|
||
| ## Changelog | ||
|
|
||
| ### 2.2.0-beta 2022-10-22 |
There was a problem hiding this comment.
Change it to ### next version.
| MyHours{ | ||
| email = "[email protected]" | ||
| password = "seatunnel" | ||
| url = "https://api2.myhours.com/api/Projects/getAll" |
There was a problem hiding this comment.
Add the schema of https://api2.myhours.com/api/Projects/getAll ?
EricJoy2048
reviewed
Nov 1, 2022
| url = "https://api2.myhours.com/api/Projects/getAll" | ||
| email = "[email protected]" | ||
| password = "seatunnel" | ||
| schema { |
There was a problem hiding this comment.
Thanks for your review, I have fixed it.
3 tasks
EricJoy2048
reviewed
Nov 2, 2022
| ## Key features | ||
|
|
||
| - [x] [batch](../../concept/connector-v2-features.md) | ||
| - [x] [stream](../../concept/connector-v2-features.md) |
There was a problem hiding this comment.
When will stream be used? And for a SaaS service, how can we get the Incremental data when use stream job?
TaoZex
requested review from
TyrantLucifer and
EricJoy2048
and removed request for
TyrantLucifer
EricJoy2048
previously approved these changes
Nov 8, 2022
.../org/apache/seatunnel/connectors/seatunnel/myhours/source/config/MyHoursSourceParameter.java
Show resolved
Hide resolved
EricJoy2048
requested review from
TyrantLucifer,
EricJoy2048 and
hailin0
and removed request for
hailin0
EricJoy2048
previously approved these changes
Nov 8, 2022
EricJoy2048
dismissed stale reviews from TyrantLucifer and themself
via
33bdf10
EricJoy2048
previously approved these changes
Nov 8, 2022
EricJoy2048
reviewed
Nov 8, 2022
EricJoy2048
approved these changes
Nov 8, 2022
TyrantLucifer
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
#3018 My Hours Source Connector
#3162 reopen
Check list
New License Guide