[Engine]Support IMap File Storage #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinKirs
changed the title
hailin0
reviewed
Nov 14, 2022
|
|
||
| public interface IMapStorage { | ||
|
|
||
| public void initialize(Map<String, Object> properties); |
There was a problem hiding this comment.
Suggested change
| public void initialize(Map<String, Object> properties); | |
| public void initialize(Map<Object, Object> properties); |
Other APIs support Object type key？
There was a problem hiding this comment.
For File Storage, we do not have a key of type Object, and all keys need to be defined internally by File
|
Please resolve the conflict. |
ic4y
reviewed
Nov 22, 2022
...torage-file/src/main/java/org/apache/seatunnel/engine/imap/storage/file/IMapFileStorage.java
Show resolved
Hide resolved
# Conflicts: # seatunnel-dist/release-docs/LICENSE # tools/dependencies/known-dependencies.txt
CalvinKirs
changed the title
EricJoy2048
approved these changes
Nov 28, 2022
EricJoy2048
approved these changes
Nov 28, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2557
Purpose of this pull request
Check list
New License Guide