Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-V2][ElasticSearch] Unified exception for ElasticSearch source & sink connector #3569

Merged

Conversation

FWLamb
Copy link
Contributor

@FWLamb FWLamb commented Nov 24, 2022

Purpose of this pull request

sub-task #2930

close #3568

Check list

@FWLamb FWLamb marked this pull request as draft November 24, 2022 08:28
@FWLamb FWLamb marked this pull request as ready for review November 24, 2022 08:45
@FWLamb
Copy link
Contributor Author

FWLamb commented Nov 24, 2022

@iture123 @Hisoka-X @TyrantLucifer PTAL

Hisoka-X
Hisoka-X previously approved these changes Nov 25, 2022
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TyrantLucifer
TyrantLucifer previously approved these changes Nov 25, 2022
@Hisoka-X Hisoka-X dismissed stale reviews from TyrantLucifer and themself via 961f14a November 25, 2022 14:58
Copy link
Contributor

@iture123 iture123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyrantLucifer TyrantLucifer merged commit b73944d into apache:dev Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Connector-V2][ElasticSearch] Unified exception for ElasticSearch source & sink connector
4 participants