Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Connector-V2][File] Support split file based on batch size #3625

Merged
merged 6 commits into from
Dec 7, 2022
Merged

[Improve][Connector-V2][File] Support split file based on batch size #3625

merged 6 commits into from
Dec 7, 2022

Conversation

TyrantLucifer
Copy link
Member

@TyrantLucifer TyrantLucifer commented Dec 1, 2022 •
edited
Loading

Purpose of this pull request

support batch size for file sink

Check list

PraveenNanda124
PraveenNanda124 reviewed Dec 1, 2022
View reviewed changes
Copy link

@PraveenNanda124 PraveenNanda124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@TyrantLucifer TyrantLucifer force-pushed the support-batch-split branch 2 times, most recently from 6f7b37e to da9df36 Compare December 3, 2022 11:41
@EricJoy2048
Copy link
Member

You can fix the dead link ci failed by merge code from dev.

@EricJoy2048
Copy link
Member

Please fix CI error.

EricJoy2048
EricJoy2048 reviewed Dec 6, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
EricJoy2048
EricJoy2048 previously approved these changes Dec 6, 2022
View reviewed changes
TaoZex
TaoZex reviewed Dec 7, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
TaoZex
TaoZex approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@TyrantLucifer TyrantLucifer merged commit f39e3a5 into apache:dev Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PraveenNanda124 PraveenNanda124 PraveenNanda124 left review comments

@TaoZex TaoZex TaoZex approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@wuchunfu wuchunfu wuchunfu approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TyrantLucifer @EricJoy2048 @wuchunfu @TaoZex @PraveenNanda124