Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Connector-V2][Kafka] Add text format for kafka sink connector #3711

Merged
merged 5 commits into from
Dec 13, 2022
Merged

[Improve][Connector-V2][Kafka] Add text format for kafka sink connector #3711

merged 5 commits into from
Dec 13, 2022

Conversation

TaoZex
Copy link
Contributor

@TaoZex TaoZex commented Dec 12, 2022 •
edited
Loading

Purpose of this pull request

#3138
Add text format for kafka sink connector

Source config：
2444e468698749a29f36deac2b273b1

Sink cnfig：
3b9460eb046bb52c503e4522e50e0f5

Ten rows of data were received：
e4ecfdeeaaa1d98061737d9ab2333b7

Check list

@TaoZex TaoZex closed this Dec 12, 2022
@TaoZex TaoZex reopened this Dec 12, 2022
@TaoZex TaoZex marked this pull request as ready for review December 12, 2022 17:37
hailin0
hailin0 reviewed Dec 13, 2022
View reviewed changes
...-e2e/connector-kafka-e2e/src/test/java/org/apache/seatunnel/e2e/connector/kafka/KafkaIT.java
}
} while (lastProcessedOffset < endOffset - 1);
}
Assertions.assertEquals(10, data.size());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check data content & format

@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 13, 2022 •
edited
Loading

Please update the doc

Hisoka-X
Hisoka-X approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liugddx liugddx merged commit 74bbd76 into apache:dev Dec 13, 2022
@TaoZex TaoZex mentioned this pull request Dec 17, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 left review comments

@liugddx liugddx liugddx approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 improve reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TaoZex @Hisoka-X @hailin0 @liugddx