Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases #3820

Merged
merged 6 commits into from
Jan 3, 2023

Conversation

Carl-Zhou-CN
Copy link
Member

Purpose of this pull request

Check list

close #3671

@Carl-Zhou-CN Carl-Zhou-CN changed the title [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases [Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases Dec 29, 2022
@hailin0
Copy link
Member

hailin0 commented Dec 31, 2022

please fix ci error

@Carl-Zhou-CN
Copy link
Member Author

@TyrantLucifer @hailin0 @Hisoka-X Please help review

@Carl-Zhou-CN
Copy link
Member Author

please fix ci error

done

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1,thanks for your contribution!

@TyrantLucifer
Copy link
Member

cc @hailin0 @Hisoka-X

@Hisoka-X Hisoka-X merged commit 7490628 into apache:dev Jan 3, 2023
lhyundeadsoul pushed a commit to lhyundeadsoul/incubator-seatunnel that referenced this pull request Jan 3, 2023
…cases (apache#3820)

* [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases

* [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases

* [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases

* [Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases

* [Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases

Co-authored-by: zhouyao <[email protected]>
lhyundeadsoul pushed a commit to lhyundeadsoul/incubator-seatunnel that referenced this pull request Jan 3, 2023
…cases (apache#3820)

* [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases

* [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases

* [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases

* [Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases

* [Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases

Co-authored-by: zhouyao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Connector-V2][IceBerg] Refactor IceBerg connector e2e test cases
4 participants