-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carl-Zhou-CN
changed the title
[Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases
[Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases
Dec 29, 2022
please fix ci error |
@TyrantLucifer @hailin0 @Hisoka-X Please help review |
done |
Hisoka-X
reviewed
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TyrantLucifer
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1,thanks for your contribution!
Hisoka-X
approved these changes
Jan 3, 2023
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Jan 3, 2023
…cases (apache#3820) * [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases * [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases * [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases * [Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases * [Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases Co-authored-by: zhouyao <[email protected]>
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Jan 3, 2023
…cases (apache#3820) * [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases * [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases * [Improve][Connector-V2][ioTdb] Refactor iceberg connector e2e test cases * [Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases * [Improve][Connector-V2][iceberg] Refactor iceberg connector e2e test cases Co-authored-by: zhouyao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide
close #3671