-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][connector-v2][FileSink] Allow the user to set the row delimiter as an empty string #3854
Conversation
@Hisoka-X @TyrantLucifer please review ,thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TaoZex please review, thanks. |
@Hisoka-X please review, thanks. |
@TyrantLucifer PTAL, thanks. |
1 similar comment
@TyrantLucifer PTAL, thanks. |
IMO, This can lead to data disruption and lost data, when user sets a empty delimiter, all data will be wrote on one line. How can we read this type file in SeaTunnel? There may be 10 rows of data before writing and only 1 row after reading. cc @EricJoy2048 @CalvinKirs Hey guys, what do you think about it? |
This case is aimed at the fact that the user data already contains a newline symbol, which allows the user to set an empty action. |
@EricJoy2048 @CalvinKirs PTAL. |
Please incorporate the latest code changes in order to pass CI. |
… as an empty string (apache#3854) Co-authored-by: zhaoliang01 <[email protected]>
If a user's text line is marked with a line delimiter, it is unnecessary to set the line delimiter, so set the line separator as an empty string
Purpose of this pull request
Check list
New License Guide