Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Remove the use of scala.Tuple in the e2e module #3974

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

laglangyue
Copy link
Contributor

Purpose of this pull request

Here are some uses of scala syntax, which may cause some errors. I think it can be replaced by Pair type

Check list

@hailin0
Copy link
Member

hailin0 commented Jan 18, 2023

image

@laglangyue update all others?

@laglangyue
Copy link
Contributor Author

image

@laglangyue update all others?

image

@laglangyue update all others?

done

@laglangyue laglangyue changed the title [e2e] Remove the grammar sugar of scala in CassandraIT [e2e] Remove the use of scala.Tuple in the e2e module Jan 18, 2023
@Hisoka-X Hisoka-X added chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. test labels Jan 18, 2023
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyrantLucifer TyrantLucifer merged commit 0bebef9 into apache:dev Jan 18, 2023
@laglangyue laglangyue deleted the fix_tuple branch February 4, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. reviewed test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants