Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][build] Give the maven module a human readable name #4114

Merged
merged 1 commit into from
Feb 15, 2023
Merged

[Improve][build] Give the maven module a human readable name #4114

merged 1 commit into from
Feb 15, 2023

Conversation

chucheng92
Copy link
Member

@chucheng92 chucheng92 commented Feb 13, 2023 •
edited
Loading

Purpose of this pull request

Give the maven module a human readable name. 4100

Check list

@chucheng92 chucheng92 force-pushed the module_name branch 2 times, most recently from c92a2f7 to 51e993a Compare February 13, 2023 05:33
@chucheng92
Copy link
Member Author

@Hisoka-X PTAL, thanks.

@Hisoka-X Hisoka-X added improve First-time contributor First-time contributor labels Feb 13, 2023
@liugddx
Copy link
Member

liugddx commented Feb 15, 2023

Please fix ci error.

@chucheng92
Copy link
Member Author

@liugddx pls approve run workflows.

@chucheng92
Copy link
Member Author

Please fix ci error.

done. PTAL. thanks

liugddx
liugddx approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TyrantLucifer
TyrantLucifer reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please offer some screen snapshot images to show the effect of the modified?

@TyrantLucifer
Copy link
Member

Could you please offer some screen snapshot images to show the effect of the modified?

cc @Hisoka-X

@chucheng92
Copy link
Member Author

Could you please offer some screen snapshot images to show the effect of the modified?

yes.

image

@TyrantLucifer TyrantLucifer merged commit d7cd601 into apache:dev Feb 15, 2023
@TyrantLucifer
Copy link
Member

Thank you for your contribution of SeaTunnel, could you please add my wechat tyrantlucifer and I invite you to contributor group?

@chucheng92 chucheng92 deleted the module_name branch February 15, 2023 09:53
@chucheng92
Copy link
Member Author

tyrantlucifer

ok. thanks

@TyrantLucifer TyrantLucifer mentioned this pull request Mar 15, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

@liugddx liugddx liugddx approved these changes

Assignees
No one assigned
Labels
approved First-time contributor First-time contributor improve reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chucheng92 @liugddx @TyrantLucifer @Hisoka-X