Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][connector-v2][PulsarSource]can't consume messages all the time #4125

Merged
merged 1 commit into from
Mar 22, 2023
Merged

[Bug][connector-v2][PulsarSource]can't consume messages all the time #4125

merged 1 commit into from
Mar 22, 2023

Conversation

lightzhao
Copy link
Contributor

Purpose of this pull request

Question: The running flag is not enabled all the time, so the message cannot be consumed.
image
Solution：Initialize setting running to true.

Check list

@lightzhao
Copy link
Contributor Author

@ashulin @Hisoka-X PTAL.

@Hisoka-X Hisoka-X requested a review from ashulin February 15, 2023 03:14
@lightzhao
Copy link
Contributor Author

@ashulin PTAL.

@lightzhao
Copy link
Contributor Author

@Hisoka-X @ashulin @TyrantLucifer PTAL.

Hisoka-X
Hisoka-X approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lightzhao
Copy link
Contributor Author

@EricJoy2048 @ashulin @TyrantLucifer PTAL.

1 similar comment
@lightzhao
Copy link
Contributor Author

@EricJoy2048 @ashulin @TyrantLucifer PTAL.

@lightzhao
Copy link
Contributor Author

@ashulin PTAL.

@lightzhao
Copy link
Contributor Author

@ashulin @TyrantLucifer PTAL.

@lightzhao
Copy link
Contributor Author

@ashulin @ EricJoy2048 PTAL.

@lightzhao
Copy link
Contributor Author

@EricJoy2048 @ashulin PTAL.

@lightzhao
Copy link
Contributor Author

Hello everyone, who has the time to help with the review, the current bug has caused the pulsar source to fail to work normally, and the data cannot be consumed.

@ashulin ashulin merged commit a6705cc into apache:dev Mar 22, 2023
@lightzhao lightzhao deleted the fix-pulsar-source-no-consume branch March 22, 2023 02:49
@Hisoka-X
Copy link
Member

Hello everyone, who has the time to help with the review, the current bug has caused the pulsar source to fail to work normally, and the data cannot be consumed.

Thanks for push this PR, sorry for response slow.

@lightzhao
Copy link
Contributor Author

Hello everyone, who has the time to help with the review, the current bug has caused the pulsar source to fail to work normally, and the data cannot be consumed.

Thanks for push this PR, sorry for response slow.
You are welcome, everyone who has time will review these pr #4302 #4246 #3990 , thank you.

MonsterChenzhuo pushed a commit to MonsterChenzhuo/incubator-seatunnel that referenced this pull request Apr 19, 2023
@lightzhao @MonsterChenzhuo
[hotfix][pulsar] Fix the bug that can't consume messages all the time. (
4b3b8c7 
apache#4125)
ic4y pushed a commit to ic4y/incubator-seatunnel that referenced this pull request May 22, 2023
@lightzhao @hailin0
[hotfix][pulsar] Fix the bug that can't consume messages all the time. (
ab8e9e0 
apache#4125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashulin ashulin ashulin approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lightzhao @Hisoka-X @ashulin