Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Transform] Add SimpleSQL transform plugin #4148

Merged
merged 9 commits into from
Mar 5, 2023
Merged

[Feature][Transform] Add SimpleSQL transform plugin #4148

merged 9 commits into from
Mar 5, 2023

Conversation

rewerma
Copy link
Contributor

@rewerma rewerma commented Feb 16, 2023

Purpose of this pull request

We can use simple SQL to transform input data. For example config:

transform {
  Sql {
    source_table_name = "fake"
    result_table_name = "fake1"
    query = "select id, concat(name, '_') as name, age+1 as age from fake where id>0"
  }
}

Check list

@rewerma rewerma changed the title [Feature][Trasform] Add SimpleSQL transform [Feature][Trasform] Add SimpleSQL transform plugin Feb 16, 2023
@davidzollo davidzollo added the First-time contributor First-time contributor label Feb 16, 2023
@davidzollo
Copy link
Contributor

The CI failed, please check and add license
image

@ashulin ashulin changed the title [Feature][Trasform] Add SimpleSQL transform plugin [Feature][Transform] Add SimpleSQL transform plugin Feb 22, 2023
@Hisoka-X Hisoka-X added this to the 2.3.1 milestone Feb 23, 2023
laglangyue and others added 2 commits March 2, 2023 16:06
* [e2e] fix split path failed in win10

* [e2e] fix style
…Is Null (#4107)

* [Improve] [Zeta] [Client] Fix Client Not Throw Exception When Error Msg Is Null

* [Improve][Zeta][Client] Reformat code with spotless

---------

Co-authored-by: tyrantlucifer <[email protected]>
@TaoZex
Copy link
Contributor

TaoZex commented Mar 2, 2023

Good Job!
Please add this feature in release-note.

@rewerma
Copy link
Contributor Author

rewerma commented Mar 3, 2023

Good Job! Please add this feature in release-note.

ok

@Hisoka-X
Copy link
Member

Hisoka-X commented Mar 4, 2023

Hi, maybe change name SimpleSQL to SQL will be better. Clear, easy to understand.

@rewerma
Copy link
Contributor Author

rewerma commented Mar 4, 2023

Hi, maybe change name SimpleSQL to SQL will be better. Clear, easy to understand.

The plugin name SQL is the same name as the old transform of Spark and Flink engine? Is the old SQL transform plugin removed?

@Hisoka-X
Copy link
Member

Hisoka-X commented Mar 4, 2023

Hi, maybe change name SimpleSQL to SQL will be better. Clear, easy to understand.

The plugin name SQL is the same name as the old transform of Spark and Flink engine? Is the old SQL transform plugin removed?

yes

rewerma and others added 2 commits March 5, 2023 00:22
# Conflicts:
#	seatunnel-engine/seatunnel-engine-client/src/main/java/org/apache/seatunnel/engine/client/job/ClientJobProxy.java
#	tools/dependencies/known-dependencies.txt
Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Transform-v2] Add a Simple SQL transform plugin with internal mem SQL engine
7 participants