-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][Spark-Translation] Fix a bug of Spark Translation when has a timestamp/date type filed in source #4226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cc @ashulin @CalvinKirs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job. cc @Hisoka-X @EricJoy2048
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Hi, can you add e2e to test this case? Thanks. |
Or modify e2e already existed.
|
This case I had help him to test in local env. The main problem is that when we invoke |
ok |
...ms-v2-e2e/src/test/java/org/apache/seatunnel/e2e/transform/TestSparkDateTimeTransformIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cc @EricJoy2048 @Hisoka-X
Purpose of this pull request
Check list
New License Guide
release-note
.