[Fix][Docs] Update jdbc doc and kafka doc #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liugddx
reviewed
Mar 21, 2023
Comment on lines
-204
to
211
| url = "jdbc:mysql://localhost:3306/test" | ||
| url = "jdbc:mysql://localhost:3306" | ||
| driver = "com.mysql.cj.jdbc.Driver" | ||
| user = "root" | ||
| password = "123456" | ||
|
|
||
| table = sink_table | ||
| database = "sink_database" | ||
| table = "sink_table" | ||
| primary_keys = ["key1", "key2", ...] |
There was a problem hiding this comment.
What's the advantage of this change?
There was a problem hiding this comment.
What's the advantage of this change?
The parameters of the dev branch connector have been changed, but not in the doc examples.These two changes were discovered when I was using the dev branch of SeaTunnel.
liugddx
approved these changes
Mar 21, 2023
It's my pleasure. |
lightzhao
approved these changes
Mar 21, 2023
MonsterChenzhuo
pushed a commit
to MonsterChenzhuo/incubator-seatunnel
that referenced
this pull request
Apr 19, 2023
Co-authored-by: chaorongzhi <[email protected]>
ic4y
pushed a commit
to ic4y/incubator-seatunnel
that referenced
this pull request
May 22, 2023
Co-authored-by: chaorongzhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
The doc of next vsersion has some problems, this pull request fixing some issues with the jdbc and kafka doc.
Check list
New License Guide
release-note.