Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][API]fix parse nested row data type key changed upper #4459

Merged
merged 2 commits into from
Apr 3, 2023
Merged

[Hotfix][API]fix parse nested row data type key changed upper #4459

merged 2 commits into from
Apr 3, 2023

Conversation

tobezhou33
Copy link
Contributor

@tobezhou33 tobezhou33 commented Mar 31, 2023 •
edited
Loading

Purpose of this pull request

Check list

@tobezhou33 tobezhou33 changed the title [hotfix][api]fix parse nested row data type key changed upper [Hotfix][API]fix parse nested row data type key changed upper Mar 31, 2023
@tobezhou33
Copy link
Contributor Author

tobezhou33 commented Mar 31, 2023 •
edited
Loading

@ashulin @Hisoka-X please help me review~ thx

@Hisoka-X Hisoka-X requested a review from ashulin March 31, 2023 03:39
EricJoy2048
EricJoy2048 previously approved these changes Mar 31, 2023
View reviewed changes
TyrantLucifer
TyrantLucifer requested changes Mar 31, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test to verify this pull request is valid.

@tobezhou33
Copy link
Contributor Author

tobezhou33 commented Mar 31, 2023 •
edited
Loading

Please add unit test to verify this pull request is valid.

it already has ut in seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java
i hava add some to verify nested row type parse field name correct @TyrantLucifer

@EricJoy2048
Copy link
Member

Please add unit test to verify this pull request is valid.

it already has ut in seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java i hava add some to verify nested row type parse field name correct

Thanks

@tobezhou33 tobezhou33 force-pushed the hotfix/parse_datatype branch from 2151849 to d60ab22 Compare April 1, 2023 07:01
TyrantLucifer
TyrantLucifer approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyrantLucifer TyrantLucifer merged commit 7441cd9 into apache:dev Apr 3, 2023
MonsterChenzhuo pushed a commit to MonsterChenzhuo/incubator-seatunnel that referenced this pull request Apr 19, 2023
@tobezhou33 @MonsterChenzhuo
[Hotfix][API] Fix parse nested row data type key changed upper (apach…
2c5c079 
…e#4459)

* [hotfix][api]fix parse nested row data type key changed upper

* [hotfix][api]add ut to verify parse field name correct

---------

Co-authored-by: zhoutao.tobeone <[email protected]>
ic4y pushed a commit to ic4y/incubator-seatunnel that referenced this pull request May 22, 2023
@tobezhou33 @EricJoy2048
[Hotfix][API] Fix parse nested row data type key changed upper (apach…
73c0904 
…e#4459)

* [hotfix][api]fix parse nested row data type key changed upper

* [hotfix][api]add ut to verify parse field name correct

---------

Co-authored-by: zhoutao.tobeone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@ashulin ashulin Awaiting requested review from ashulin

@EricJoy2048 EricJoy2048 Awaiting requested review from EricJoy2048

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobezhou33 @EricJoy2048 @Hisoka-X @TyrantLucifer