-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix] [seatunnel-connectors-v2][SFTP] Fix incorrect exception handling logic #4720
Conversation
…block is returned, the method ends execution and the return statement in a try block will no longer be executed.
Return cannot be used in a finally block. When a return in a finally block is returned, the method ends execution and the return statement in a try block will no longer be executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! LGTM
Please check your CI @lucklilili |
# Conflicts: # seatunnel-connectors-v2/connector-file/connector-file-sftp/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sftp/system/SFTPFileSystem.java
…block is returned, the method ends execution and the return statement in a try block will no longer be executed. V2, Run 'mvn spocles: apply' to fix these conflicts.
@zhilinli123 The mvn spotless: apply check CI has been executed and a new pull request has been submitted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Please wait CI
…stem] Fix incorrect exception handling logic(apache#4719)
…stem] Fix incorrect exception handling logic(apache#4719)
@lucklilili Thanks! |
Return cannot be used in a finally block. When a return in a finally block is returned, the method ends execution and the return statement in a try block will no longer be executed.
@#4719 (comment)
Purpose of this pull request
Fix Return cannot be used in a finally block. When a return in a finally block is returned, the method ends execution and the return statement in a try block will no longer be executed.
Check list
New License Guide
release-note
.