[Bug] [seatunnel-formats] Allow the entry in the map to be null and allow the key in the entry to be null #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a null check while splitting the kv in the TextDeserializationSchema. Not having this check could potentially lead to a crash if 'kvs' has less than two elements. Now, the function will return null in this case, significantly improving reliability."
|
|
added 3 commits
August 11, 2023 16:49
Modified the TextDeserializationSchema to allow key-value pairs with null values. This adjustment helps to handle data records with missing values more accurately. The code was also reformatted for improved readability.
Tidied up the Builder constructor in TextDeserializationSchema by removing unnecessary empty lines. This change improves code readability and consistency with the rest of the class?
NickCodeJourney
changed the title
Hisoka-X
approved these changes
Aug 26, 2023
EricJoy2048
approved these changes
Sep 11, 2023
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
…llow the key in the entry to be null (apache#5277) * 🐛 "Add null check in text deserialization This commit adds a null check while splitting the kv in the TextDeserializationSchema. Not having this check could potentially lead to a crash if 'kvs' has less than two elements. Now, the function will return null in this case, significantly improving reliability." * 🐛 Refactor text deserialization, allow null value assignments Modified the TextDeserializationSchema to allow key-value pairs with null values. This adjustment helps to handle data records with missing values more accurately. The code was also reformatted for improved readability. * 🎨 Refactor Builder constructor in TextDeserializationSchema Tidied up the Builder constructor in TextDeserializationSchema by removing unnecessary empty lines. This change improves code readability and consistency with the rest of the class? * ✅ Add test case where the value is empty and the key is empty in the map --------- Co-authored-by: yangpeng <[email protected]>
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
…llow the key in the entry to be null (apache#5277) * 🐛 "Add null check in text deserialization This commit adds a null check while splitting the kv in the TextDeserializationSchema. Not having this check could potentially lead to a crash if 'kvs' has less than two elements. Now, the function will return null in this case, significantly improving reliability." * 🐛 Refactor text deserialization, allow null value assignments Modified the TextDeserializationSchema to allow key-value pairs with null values. This adjustment helps to handle data records with missing values more accurately. The code was also reformatted for improved readability. * 🎨 Refactor Builder constructor in TextDeserializationSchema Tidied up the Builder constructor in TextDeserializationSchema by removing unnecessary empty lines. This change improves code readability and consistency with the rest of the class? * ✅ Add test case where the value is empty and the key is empty in the map --------- Co-authored-by: yangpeng <[email protected]>
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
…llow the key in the entry to be null (apache#5277) * 🐛 "Add null check in text deserialization This commit adds a null check while splitting the kv in the TextDeserializationSchema. Not having this check could potentially lead to a crash if 'kvs' has less than two elements. Now, the function will return null in this case, significantly improving reliability." * 🐛 Refactor text deserialization, allow null value assignments Modified the TextDeserializationSchema to allow key-value pairs with null values. This adjustment helps to handle data records with missing values more accurately. The code was also reformatted for improved readability. * 🎨 Refactor Builder constructor in TextDeserializationSchema Tidied up the Builder constructor in TextDeserializationSchema by removing unnecessary empty lines. This change improves code readability and consistency with the rest of the class? * ✅ Add test case where the value is empty and the key is empty in the map --------- Co-authored-by: yangpeng <[email protected]>
gnehil
pushed a commit
to gnehil/seatunnel
that referenced
this pull request
Oct 12, 2023
…llow the key in the entry to be null (apache#5277) * 🐛 "Add null check in text deserialization This commit adds a null check while splitting the kv in the TextDeserializationSchema. Not having this check could potentially lead to a crash if 'kvs' has less than two elements. Now, the function will return null in this case, significantly improving reliability." * 🐛 Refactor text deserialization, allow null value assignments Modified the TextDeserializationSchema to allow key-value pairs with null values. This adjustment helps to handle data records with missing values more accurately. The code was also reformatted for improved readability. * 🎨 Refactor Builder constructor in TextDeserializationSchema Tidied up the Builder constructor in TextDeserializationSchema by removing unnecessary empty lines. This change improves code readability and consistency with the rest of the class? * ✅ Add test case where the value is empty and the key is empty in the map --------- Co-authored-by: yangpeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the entry in the map to be null and allow the key in the entry to be null
Purpose of this pull request
Check list
New License Guide
release-note.