Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support flow control in zeta #5502

Merged
merged 8 commits into from
Sep 16, 2023
Merged

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

  1. Add SourceReceivedBytes, SourceReceivedBytesPerSeconds, SinkWriteBytes, SinkWriteBytesPerSeconds as new bytes metrics.
  2. Add new config read_limit.rows_per_second and read_limit.bytes_per_second to limit read speed. Only work on Zeta at now.

Check list

@Hisoka-X Hisoka-X linked an issue Sep 15, 2023 that may be closed by this pull request
3 tasks
@Hisoka-X Hisoka-X added feature New feature Zeta labels Sep 15, 2023
@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Sep 15, 2023
@hailin0
Copy link
Member

hailin0 commented Sep 15, 2023

Please add usage documentation

@Hisoka-X
Copy link
Member Author

Please add usage documentation

Done

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.

SqlType sqlType = dataType.getSqlType();
switch (sqlType) {
case STRING:
return ((String) v).length();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

length does not return byte length, it will return the unique code length.
But it seems we don't have a better way to get the byte length.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

hailin0
hailin0 previously approved these changes Sep 15, 2023
@hailin0
Copy link
Member

hailin0 commented Sep 15, 2023

check ci error

@hailin0 hailin0 dismissed their stale review September 15, 2023 12:10

check ci error

@Hisoka-X
Copy link
Member Author

check ci error

Fixed.

@hailin0 hailin0 merged commit 0ce1712 into apache:dev Sep 16, 2023
@Hisoka-X Hisoka-X deleted the speed-limit branch September 18, 2023 03:11
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Zeta] Reading speed limit of source connector
3 participants