-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support flow control in zeta #5502
Conversation
Please add usage documentation |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM.
SqlType sqlType = dataType.getSqlType(); | ||
switch (sqlType) { | ||
case STRING: | ||
return ((String) v).length(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
length
does not return byte length, it will return the unique code length.
But it seems we don't have a better way to get the byte length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
check ci error |
Fixed. |
Purpose of this pull request
SourceReceivedBytes
,SourceReceivedBytesPerSeconds
,SinkWriteBytes
,SinkWriteBytesPerSeconds
as new bytes metrics.read_limit.rows_per_second
andread_limit.bytes_per_second
to limit read speed. Only work on Zeta at now.Check list
New License Guide
release-note
.