Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Test] Add test for ResourceManager to keep task will be deployed in different node #5518

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

  1. Refactor AbstractResourceManager::sendToMember, change return type to CompletableFuture not InvocationFuture. (We can create CompletableFuture easy but InvocationFuture not, and InvocationFuture is child class of CompletableFuture. So we can do that)
  2. Add FakeResourceManager used to test ResourceManager logic.
  3. Add test case to make sure our task will be deployed different node randomly.

Does this PR introduce any user-facing change?

No

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X closed this Sep 19, 2023
@Hisoka-X Hisoka-X reopened this Sep 19, 2023
@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Sep 19, 2023
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit a6e5850 into apache:dev Oct 7, 2023
@Hisoka-X Hisoka-X deleted the ut-for-resourcemanager branch October 8, 2023 03:04
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
…loyed in different node (apache#5518)

* [Improve][Test] Add test for ResourceManager to keep task will be deployed in different node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants