[Improve][Connector-v2] Redis support select db #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TyrantLucifer
requested changes
Oct 4, 2023
docs/en/connector-v2/sink/Redis.md
Outdated
| @@ -20,6 +20,7 @@ Used to write data to Redis. | |||
| | data_type | string | yes | - | | |||
| | user | string | no | - | | |||
| | auth | string | no | - | | |||
| | db_num | int | no | - | | |||
There was a problem hiding this comment.
Suggested change
| | db_num | int | no | - | | |
| | db_num | int | no | 0 | |
| @@ -40,6 +40,7 @@ public class RedisParameters implements Serializable { | |||
| private String host; | |||
| private int port; | |||
| private String auth = ""; | |||
| private Integer dbNum; | |||
There was a problem hiding this comment.
Suggested change
| private Integer dbNum; | |
| private int dbNum; |
Comment on lines
123
to
125
| if (dbNum != null && dbNum > 0) { | ||
| jedis.select(dbNum); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (dbNum != null && dbNum > 0) { | |
| jedis.select(dbNum); | |
| } | |
| jedis.select(dbNum); |
| return new JedisWrapper(jedisCluster); | ||
| JedisWrapper jedisWrapper = new JedisWrapper(jedisCluster); | ||
| if (dbNum != null && dbNum > 0) { | ||
| jedisWrapper.select(dbNum); |
xiaofan2022
commented
Oct 7, 2023
Comment on lines
123
to
125
| if (dbNum != null && dbNum > 0) { | ||
| jedis.select(dbNum); | ||
| } |
| @@ -40,6 +40,7 @@ public class RedisParameters implements Serializable { | |||
| private String host; | |||
| private int port; | |||
| private String auth = ""; | |||
| private Integer dbNum; | |||
|
update PR title ? |
Hisoka-X
reviewed
Oct 11, 2023
| .intType() | ||
| .defaultValue(0) | ||
| .withDescription( | ||
| "redis database index id, It is connected to db 0 by default"); |
There was a problem hiding this comment.
Suggested change
| "redis database index id, It is connected to db 0 by default"); | |
| "Redis database index id, it is connected to db 0 by default"); |
Hisoka-X
changed the title
Hisoka-X
approved these changes
Oct 13, 2023
done |
hailin0
approved these changes
Oct 17, 2023
TyrantLucifer
approved these changes
Oct 17, 2023
|
Thanks @xiaofan2022 and @hailin0 @TyrantLucifer for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
redis select_db index #5415
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test
Check list
New License Guide
release-note.