-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][LocalFile] parquet use system timezone #5605
Conversation
Thanks @liunaijie . Could you add some test case for this change? |
Good pr, overall LGTM, could you please offer some test cases to verify it worked? |
@TyrantLucifer @Hisoka-X I add a unit test, PTAL, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @liunaijie !
...test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/ParquetReadStrategyTest.java
Outdated
Show resolved
Hide resolved
…/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/ParquetReadStrategyTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liunaijie Good pr, overall LGTM, please resolve the issue of ci running error
restarted the failed job. now all passed. |
Merged. Thanks @liunaijie and @TyrantLucifer @wuchunfu for review. |
Purpose of this pull request
now parquet convert hard code timezone to +8, change to use system default.
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.