Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][LocalFile] parquet use system timezone #5605

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

now parquet convert hard code timezone to +8, change to use system default.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@liunaijie liunaijie changed the title [Improve] use system timezone [Improve][LocalFile] parquet use system timezone Oct 10, 2023
@Hisoka-X
Copy link
Member

Thanks @liunaijie . Could you add some test case for this change?

@TyrantLucifer
Copy link
Member

Good pr, overall LGTM, could you please offer some test cases to verify it worked?

@liunaijie
Copy link
Member Author

@TyrantLucifer @Hisoka-X I add a unit test, PTAL, thanks.

Hisoka-X
Hisoka-X previously approved these changes Oct 26, 2023
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @liunaijie !

…/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/ParquetReadStrategyTest.java
Copy link
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liunaijie Good pr, overall LGTM, please resolve the issue of ci running error

@liunaijie
Copy link
Member Author

@liunaijie Good pr, overall LGTM, please resolve the issue of ci running error

restarted the failed job. now all passed.

@Hisoka-X Hisoka-X merged commit b3e1351 into apache:dev Oct 26, 2023
@Hisoka-X
Copy link
Member

Merged. Thanks @liunaijie and @TyrantLucifer @wuchunfu for review.

@liunaijie liunaijie deleted the parquet_timezone branch October 31, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants