Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Remove useless ReadonlyConfig flatten feature #5612

Merged
merged 11 commits into from
Oct 12, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR try to remove flattern in ReadonlyConfig.
Before this PR, as default behavior, ReadonlyConfig will try to flattern config key.

// eg:
mapkey {
  inner {
   key = value
  }
}

// convert to
mapkey.inner.key = value

This feature seems unnecessary, and will affect the reading of other config that do not want flattern, and will cause errors when handling null values.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

exist test.

Check list

@Hisoka-X Hisoka-X added core SeaTunnel core module api labels Oct 11, 2023
ruanwenjun
ruanwenjun previously approved these changes Oct 12, 2023
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun
Copy link
Member

This PR will close #5597

@Hisoka-X Hisoka-X linked an issue Oct 12, 2023 that may be closed by this pull request
3 tasks
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Hisoka-X Hisoka-X merged commit 243edfe into apache:dev Oct 12, 2023
@Hisoka-X Hisoka-X deleted the remove-readonlyconfig-parse-feature branch October 12, 2023 07:05
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
ruanwenjun added a commit to ruanwenjun/incubator-seatunnel that referenced this pull request Nov 6, 2023
* [Improve] Remove useless ReadonlyConfig flatten feature (apache#5612)

---------

Co-authored-by: Wenjun Ruan <[email protected]>

* update

---------

Co-authored-by: Wenjun Ruan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Support represent null in ReadonlyConfig
3 participants