-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve] Remove useless ReadonlyConfig flatten feature #5612
[Improve] Remove useless ReadonlyConfig flatten feature #5612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/ConfigAdapter.java
Outdated
Show resolved
Hide resolved
…tion/ConfigAdapter.java Co-authored-by: Wenjun Ruan <[email protected]>
This PR will close #5597 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
--------- Co-authored-by: Wenjun Ruan <[email protected]>
* [Improve] Remove useless ReadonlyConfig flatten feature (apache#5612) --------- Co-authored-by: Wenjun Ruan <[email protected]> * update --------- Co-authored-by: Wenjun Ruan <[email protected]>
Purpose of this pull request
This PR try to remove
flattern
in ReadonlyConfig.Before this PR, as default behavior, ReadonlyConfig will try to flattern config key.
This feature seems unnecessary, and will affect the reading of other config that do not want flattern, and will cause errors when handling null values.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
exist test.
Check list
New License Guide
release-note
.