[Improve] Remove useless transform code come from setTypeInfo
#5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
commented
Oct 17, 2023
| SeaTunnelDataType<?> seaTunnelDataType = TypeConverterUtils.convert(stream.schema()); | ||
| transform.setTypeInfo(seaTunnelDataType); |
There was a problem hiding this comment.
Missed refactor to remove it.
|
LGTM |
5 tasks
ruanwenjun
previously approved these changes
Oct 19, 2023
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/SQLTransform.java
Outdated
Show resolved
Hide resolved
hailin0
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR add default implement for
SeaTunnelTransform::setTypeInfoandSeaTunnelPluginLifeCycle::prepare. So connector shouldn't implement it cause it marked as deprecated. Also remove all transform connector useless code came from implementSeaTunnelTransform::setTypeInfo.Does this PR introduce any user-facing change?
No
How was this patch tested?
exist test.
Check list
New License Guide
release-note.