Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zeta][Tool] Move generate_client_protocol.sh to engine module #5667

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR move generate_client_protocol.sh to engine module. Because it is a tool only for zeta engine.
Also do some change so the generated file will in seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/protocol/codec. Don't need copy it any more.

Does this PR introduce any user-facing change?

no

How was this patch tested?

Tested in local. It work fine.

Check list

@Hisoka-X
Copy link
Member Author

cc @EricJoy2048 @ic4y

@hailin0
Copy link
Member

hailin0 commented Oct 25, 2023

LGTM

@liugddx liugddx merged commit 6915f7b into apache:dev Oct 26, 2023
@Hisoka-X Hisoka-X deleted the move-shell branch November 3, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants