Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Add default implement for SeaTunnelSource::getProducedType #5670

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR add default implement for SeaTunnelSource::getProducedType. So we can remove all implement in SeaTunnelSource if it implement TableSourceFactory. Also remove some prepare method of these SeaTunnelSource.

Does this PR introduce any user-facing change?

No

How was this patch tested?

exist test.

Check list

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit a04add6 into apache:dev Oct 24, 2023
@Hisoka-X Hisoka-X deleted the add-default-for-getproducetype branch October 24, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants