[Feature] FakeSource support MultipleTable #5766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_fakeSourceSupportMultipleTable
branch
5 times, most recently
from
efbcb92 to
fe14cfa
Compare
ruanwenjun
changed the title
ruanwenjun
force-pushed
the
dev_wenjun_fakeSourceSupportMultipleTable
branch
6 times, most recently
from
8edcb52 to
61d3371
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fakeSourceSupportMultipleTable
branch
from
61d3371 to
86788c0
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fakeSourceSupportMultipleTable
branch
from
86788c0 to
1d9e779
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fakeSourceSupportMultipleTable
branch
from
1d9e779 to
7de401b
Compare
ruanwenjun
changed the title
ruanwenjun
force-pushed
the
dev_wenjun_fakeSourceSupportMultipleTable
branch
5 times, most recently
from
7e9094a to
7075e19
Compare
Hisoka-X
reviewed
Nov 15, 2023
| parseFromConfig(fakeSourceRootConfig); | ||
| } | ||
| // validate | ||
| assert fakeConfigs != null; |
There was a problem hiding this comment.
I think the assert will not work by default. Please use com.google.common.base.Preconditions.checkNotNull.
hailin0
reviewed
Nov 15, 2023
| @@ -209,9 +209,9 @@ public SeaTunnelDataType<?> toSeaTunnelType( | |||
| case DATE: | |||
| return LocalTimeType.LOCAL_DATE_TYPE; | |||
| case DATETIME: | |||
| return LocalTimeType.LOCAL_DATE_TIME_TYPE; | |||
| case TIMESTAMP: | |||
| return LocalTimeType.LOCAL_TIME_TYPE; | |||
There was a problem hiding this comment.
mapping DATETIME to LOCAL_DATE_TIME_TYPE ?
There was a problem hiding this comment.
The DATETIME should convert to LocalTime and TIMESTAMP should convert to LOCAL_DATE_TIME_TYPE
There was a problem hiding this comment.
I revert this change.
ruanwenjun
force-pushed
the
dev_wenjun_fakeSourceSupportMultipleTable
branch
2 times, most recently
from
8fabd05 to
4afca2c
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fakeSourceSupportMultipleTable
branch
from
4afca2c to
a1dd591
Compare
Hisoka-X
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
FakeSource support generate multiple different CatalogTable. This will be used for testing multiple table feature for sink.
Does this PR introduce any user-facing change?
How was this patch tested?
Tested by UT and e2e case
Check list
New License Guide
release-note.