[BUG][Connector-V2][Http] fix bug http config no schema option and improve e2e test add case #5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyyyyyssss
changed the title
jackyyyyyssss
changed the title
Hisoka-X
reviewed
Nov 30, 2023
...ttp-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSource.java
Show resolved
Hide resolved
Hisoka-X
reviewed
Nov 30, 2023
| @@ -67,7 +67,7 @@ public class HttpConfig { | |||
| public static final Option<ResponseFormat> FORMAT = | |||
| Options.key("format") | |||
| .enumType(ResponseFormat.class) | |||
| .defaultValue(ResponseFormat.JSON) | |||
| .noDefaultValue() | |||
There was a problem hiding this comment.
I think you should not change the default value of format. Because it only worked when user configure Http source with schema config. Please refer https://github.com/apache/seatunnel/pull/5939/files#diff-7c704c6a3927123b31b41483102f286339da3832309810496f19410c2548f06fR118-R150
There was a problem hiding this comment.
Removing the default value of JSON is due to validation causing it to never run until there is no schema to take a branch
There was a problem hiding this comment.
oh I see. How about add new ResponseFormat TEXT? Then set it as default value. It used when no schema config. Also please update the doc. Thanks
There was a problem hiding this comment.
done PTAL @Hisoka-X
hailin0
approved these changes
Dec 2, 2023
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Dec 19, 2023
…prove e2e test add case (apache#5939)
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
…prove e2e test add case (apache#5939)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
fix bug http config no schema option and improve e2e test add case cover
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.