[Feature] [rest-api] get finished jobs info #5949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Dec 6, 2023
Comment on lines
146
to
154
| Awaitility.await() | ||
| .atMost(2, TimeUnit.MINUTES) | ||
| .untilAsserted( | ||
| () -> | ||
| Assertions.assertEquals( | ||
| JobStatus.RUNNING, | ||
| seaTunnelServer | ||
| .getCoordinatorService() | ||
| .getJobStatus(Long.parseLong(jobId)))); |
There was a problem hiding this comment.
Why removed this?
I tested it on my machine and found that it gets stuck here because the task has already been completed.
The status of the job will be tested below, so I think this place can be removed.
...2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/RestApiIT.java
Outdated
Show resolved
Hide resolved
Hisoka-X
previously approved these changes
Dec 7, 2023
ruanwenjun
reviewed
Dec 8, 2023
...tunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/RestConstant.java
Outdated
Show resolved
Hide resolved
Yes, I agree with you. We need a API to get the jobs list and can use param to filter the result of the specified state. |
added 3 commits
December 13, 2023 13:34
|
Please fix ci. Thanks |
added 2 commits
December 13, 2023 18:55
EricJoy2048
approved these changes
Dec 14, 2023
Hisoka-X
approved these changes
Dec 14, 2023
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Dec 19, 2023
--------- Co-authored-by: gdliu3 <[email protected]>
|
@liugddx The url in the |
Thanks for reminding. |
3 tasks
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
--------- Co-authored-by: gdliu3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #5772
Does this PR introduce any user-facing change?
add a rest api for get finished jobs info.
How was this patch tested?
ut
Check list
New License Guide
release-note.