Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector] add starrocks save_mode #6029

Merged
merged 41 commits into from
Jan 12, 2024

Conversation

chl-wxp
Copy link
Contributor

@chl-wxp chl-wxp commented Dec 19, 2023

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@hailin0 hailin0 changed the title [feature] add_starrocks_save_mode [Feature][Connector] add starrocks save_mode Dec 19, 2023
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation

@chl-wxp
Copy link
Contributor Author

chl-wxp commented Jan 5, 2024

Please update the documentation

added

@EricJoy2048 EricJoy2048 added this to the 2.3.4 milestone Jan 5, 2024
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not remove this ddl and use savemode?

StarRocksIT.java

private static final String DDL_SINK = ...

https://github.com/apache/seatunnel/pull/6029/files#diff-40a4a1be8ee6ae052ddce2c338818c1f08199daf089ede3e82cc5a351a2521d6R66

@chl-wxp
Copy link
Contributor Author

chl-wxp commented Jan 10, 2024

why not remove this ddl and use savemode?

StarRocksIT.java

private static final String DDL_SINK = ...

https://github.com/apache/seatunnel/pull/6029/files#diff-40a4a1be8ee6ae052ddce2c338818c1f08199daf089ede3e82cc5a351a2521d6R66

updated

@chl-wxp
Copy link
Contributor Author

chl-wxp commented Jan 10, 2024

why not remove this ddl and use savemode?

StarRocksIT.java

private static final String DDL_SINK = ...

https://github.com/apache/seatunnel/pull/6029/files#diff-40a4a1be8ee6ae052ddce2c338818c1f08199daf089ede3e82cc5a351a2521d6R66

image

@chl-wxp
Copy link
Contributor Author

chl-wxp commented Jan 10, 2024

why not remove this ddl and use savemode?

StarRocksIT.java

private static final String DDL_SINK = ...

https://github.com/apache/seatunnel/pull/6029/files#diff-40a4a1be8ee6ae052ddce2c338818c1f08199daf089ede3e82cc5a351a2521d6R66

deleted

@EricJoy2048 EricJoy2048 merged commit 66b0f1e into apache:dev Jan 12, 2024
6 checks passed
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants