Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Implement SFTP source/sink factory #6184

Closed
wants to merge 1 commit into from

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR implement SFTP source/sink factory

Does this PR introduce any user-facing change?

no

How was this patch tested?

exist test.

Check list

@EricJoy2048
Copy link
Member

Please add Multiple Table Test Cases

Copy link
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be return FileSystemType.SFTP.getFileSystemPluginName();

Comment on lines +38 to +41
@Override
public String getPluginName() {
return FileSystemType.OSS.getFileSystemPluginName();
}
Copy link
Member

@wuchunfu wuchunfu Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be return FileSystemType.SFTP.getFileSystemPluginName();

@wuchunfu
Copy link
Member

@Hisoka-X Please resolve the conflict, thanks.

@Hisoka-X
Copy link
Member Author

closed by #7668 and #7824

@Hisoka-X Hisoka-X closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants