Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][API] Support hocon style declare row type in generic type #6187

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

CheneyYin
Copy link
Contributor

@CheneyYin CheneyYin commented Jan 11, 2024

Purpose of this pull request

close:

This PR can keep backward compatibility. So, the following schema declaration is available.

schema {
  fields {
    # Hocon style declare row type in generic type
    map0 = "map<string, {c_int = int, c_string = string, c_row = {c_int = int}}>"
    # Json style declare row type in generic type
    map1 = "map<string, {\"c_int\":\"int\", \"c_string\":\"string\", \"c_row\":{\"c_int\":\"int\"}}>"
  }
}

Does this PR introduce any user-facing change?

Update schema-feature.md.

How was this patch tested?

Add new test cases.

Check list

@CheneyYin CheneyYin force-pushed the feat-declare-row-type branch from 2ccac82 to 24e9301 Compare January 11, 2024 12:12
@CheneyYin CheneyYin marked this pull request as ready for review January 11, 2024 14:44
@CheneyYin CheneyYin marked this pull request as draft January 12, 2024 02:47
@CheneyYin CheneyYin force-pushed the feat-declare-row-type branch from 24e9301 to 7661fcc Compare January 13, 2024 07:15
@CheneyYin CheneyYin marked this pull request as ready for review January 13, 2024 07:17
@CheneyYin CheneyYin force-pushed the feat-declare-row-type branch from 7661fcc to 4d0fd52 Compare January 13, 2024 07:24
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doc to schema-feature.md

@CheneyYin CheneyYin force-pushed the feat-declare-row-type branch from 4d0fd52 to 031b67b Compare January 15, 2024 12:49
@CheneyYin
Copy link
Contributor Author

Please add doc to schema-feature.md

Done

@CheneyYin
Copy link
Contributor Author

PTAL @Hisoka-X @hailin0

@Hisoka-X
Copy link
Member

Thanks @CheneyYin !

@hailin0 hailin0 merged commit a9bc5ca into apache:dev Jan 17, 2024
6 checks passed
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants