Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Oracle-CDC] Support custom table primary key #6216

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[Feature][Oracle-CDC] Support custom table primary key #6216

merged 1 commit into from
Jan 17, 2024

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Jan 15, 2024

Purpose of this pull request

[Oracle-CDC] Support custom table primary key
link #6106

Does this PR introduce any user-facing change?

Add new config key

How was this patch tested?

Added

Check list

@hailin0 hailin0 requested a review from Carl-Zhou-CN January 15, 2024 13:45
@hailin0 hailin0 force-pushed the dev-support-cdc-custom-primarykey branch from 853594f to 2f755cf Compare January 16, 2024 03:11
hailin0
hailin0 commented Jan 16, 2024
View reviewed changes
...acle-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/OracleCDCIT.java
@@ -221,6 +221,52 @@ public void testOracleCdcCheckDataWithNoPrimaryKey(TestContainer container) thro
});
}

@TestTemplate
public void testOracleCdcCheckDataWithCustomPrimaryKey(TestContainer container)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this e2e is passed
image

@hailin0 hailin0 marked this pull request as ready for review January 16, 2024 13:47
@Carl-Zhou-CN Carl-Zhou-CN mentioned this pull request Jan 16, 2024
Closed
3 tasks
Carl-Zhou-CN
Carl-Zhou-CN approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will make this end-to-end (E2E) stable in the future

@hailin0 hailin0 merged commit ae4240c into apache:dev Jan 17, 2024
7 of 8 checks passed
@hailin0 hailin0 mentioned this pull request Jan 18, 2024
Merged
4 tasks
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
@hailin0
[Feature][Oracle-CDC] Support custom table primary key (apache#6216)
f12605b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carl-Zhou-CN Carl-Zhou-CN Carl-Zhou-CN approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved cdc improve oracle reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hailin0 @Hisoka-X @Carl-Zhou-CN