Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Add SaveMode log of process detail #6375

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Feb 23, 2024

Purpose of this pull request

This PR add savemode log of process detail. Before this PR, all savemode operations were black boxes, and users did not know what specific operations were performed. This PR adds a standardized interface to implement specific behaviors in the print savemode process.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X marked this pull request as ready for review February 26, 2024 02:02
@Hisoka-X Hisoka-X requested review from hailin0 and EricJoy2048 March 11, 2024 07:36
hailin0
hailin0 previously approved these changes Mar 11, 2024
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 merged commit b0d70ce into apache:dev Mar 20, 2024
5 checks passed
@Hisoka-X Hisoka-X deleted the savemode-handler-log branch March 21, 2024 06:28
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants