Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][Zeta] Fix job deadlock when schema change #6389

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Feb 26, 2024

Purpose of this pull request

[Zeta] Fix job deadlock when schema change

Execute timeline:

  1. runningTask.triggerSchemaChangeBeforeCheckpoint().get() starting
  2. SourceFlowLifeCycle#triggerBarrier(Barrier barrier) executed, schemaChangePhase is null at this time
  3. runningTask.triggerSchemaChangeBeforeCheckpoint().get() end
  4. SourceFlowLifeCycle#notifyCheckpointEnd(long checkpointId) executed, , schemaChangePhase is null at this time
  5. schemaChangePhase.set(SchemaChangePhase.createBeforePhase()) executed
  6. SourceFlowLifeCycle#collect() execute, check schemaChanging() is true, job enter an endless loop

Does this PR introduce any user-facing change?

No

How was this patch tested?

Check list

@Hisoka-X
Copy link
Member

Please add test case.

@hailin0
Copy link
Member Author

hailin0 commented Mar 6, 2024

Please add test case.

@Hisoka-X
Currently not possible to add testcase because the ddl event capture has not been developed yet.

@Hisoka-X Hisoka-X merged commit e1a81ac into apache:dev Mar 6, 2024
4 checks passed
@hailin0
Copy link
Member Author

hailin0 commented May 31, 2024

fix #5125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants