[Bug][connector-jdbc] JDBC get primitive type null value bug (#6567) #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lastbus for open this PR! Could you follow the guide to open ci on your fork repository? https://github.com/apache/seatunnel/pull/6569/checks?check_run_id=23047162515. Also, please add test case for this bug. |
|
cc @mosence |
|
Could you add a negative test case to prove the change worked? You can add it into jdbc e2e test case. |
|
By the way, we try fix it before with #5560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
According to the JDK JDBC interface, when converting to a primitive type, if the column value was
null, the returned values would be the default value of the corresponding primitive type. For example if the value of an type int in MySQL database isnull, but in Hive it will be0. This is a bug.Does this PR introduce any user-facing change?
No
How was this patch tested?
yes
Check list
No