-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][Connector kafka]Fix Kafka consumer stop fetching after TM node restarted #7233
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
...rg/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumeratorTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.seatunnel.connectors.seatunnel.kafka.source; | ||
|
||
import org.apache.kafka.clients.admin.AdminClient; | ||
import org.apache.kafka.clients.admin.KafkaAdminClient; | ||
import org.apache.kafka.clients.admin.ListOffsetsResult; | ||
import org.apache.kafka.common.KafkaFuture; | ||
import org.apache.kafka.common.TopicPartition; | ||
|
||
import org.junit.jupiter.api.Assertions; | ||
import org.junit.jupiter.api.Test; | ||
import org.mockito.Mockito; | ||
|
||
import java.util.Arrays; | ||
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Optional; | ||
|
||
class KafkaSourceSplitEnumeratorTest { | ||
|
||
@Test | ||
void addSplitsBack() { | ||
// prepare | ||
TopicPartition partition = new TopicPartition("test", 0); | ||
|
||
AdminClient adminClient = Mockito.mock(KafkaAdminClient.class); | ||
Mockito.when(adminClient.listOffsets(Mockito.any(java.util.Map.class))) | ||
.thenReturn( | ||
new ListOffsetsResult( | ||
new HashMap< | ||
TopicPartition, | ||
KafkaFuture<ListOffsetsResult.ListOffsetsResultInfo>>() { | ||
{ | ||
put( | ||
partition, | ||
KafkaFuture.completedFuture( | ||
new ListOffsetsResult.ListOffsetsResultInfo( | ||
0, 0, Optional.of(0)))); | ||
} | ||
})); | ||
|
||
// test | ||
Map<TopicPartition, KafkaSourceSplit> assignedSplit = | ||
new HashMap<TopicPartition, KafkaSourceSplit>() { | ||
{ | ||
put(partition, new KafkaSourceSplit(null, partition)); | ||
} | ||
}; | ||
Map<TopicPartition, KafkaSourceSplit> pendingSplit = new HashMap<>(); | ||
List<KafkaSourceSplit> splits = Arrays.asList(new KafkaSourceSplit(null, partition)); | ||
KafkaSourceSplitEnumerator enumerator = | ||
new KafkaSourceSplitEnumerator(adminClient, pendingSplit, assignedSplit); | ||
enumerator.addSplitsBack(splits, 1); | ||
Assertions.assertTrue(pendingSplit.size() == splits.size()); | ||
Assertions.assertNull(assignedSplit.get(partition)); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case can be optimized. For example, we can directly construct a new
KafkaSourceSplitEnumerator
class, and then initialize ourpendingSplit
andassginSplit
by override theopen
method. Then we can callpublic void addSplitsBack(List<KafkaSourceSplit> splits, int subtaskId)
for testing. Please referseatunnel/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/resourcemanager/FakeResourceManager.java
Line 43 in 1e7c78d