[Improve][Connector-V2] update vectorType #7446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
corgy-w
force-pushed
the
update-vector-type
branch
from
a93f7ed to
835e43b
Compare
Hisoka-X
reviewed
Aug 22, 2024
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/BufferUtil.java
Outdated
Show resolved
Hide resolved
corgy-w
force-pushed
the
update-vector-type
branch
2 times, most recently
from
38605ac to
abf9a6d
Compare
Hisoka-X
reviewed
Aug 23, 2024
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/BufferUtil.java
Outdated
Show resolved
Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/BufferUtil.java
Outdated
Show resolved
Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/BufferUtil.java
Outdated
Show resolved
Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/BufferUtil.java
Outdated
Show resolved
Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/BufferUtil.java
Outdated
Show resolved
Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/BufferUtil.java
Outdated
Show resolved
Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/BufferUtil.java
Outdated
Show resolved
Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/BufferUtil.java
Outdated
Show resolved
Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/BufferUtil.java
Outdated
Show resolved
Hide resolved
| List<Float> vector = new ArrayList<>(); | ||
| for (Object o : (Object[]) rs.getObject(fieldIndex)) { | ||
| vector.add(Float.parseFloat(o.toString())); | ||
| Object[] objects = (Object[]) rs.getObject(fieldIndex); |
corgy-w
force-pushed
the
update-vector-type
branch
from
a6d9d5b to
7c10033
Compare
Hisoka-X
approved these changes
Aug 24, 2024
hailin0
approved these changes
Aug 24, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Aug 29, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
issue : #7445
need wait pr: #7375 to be completed, some minor emendations are required.
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.