Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Document] Fix paimon.apache.org deadlink #7504

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

FuYouJ
Copy link
Contributor

@FuYouJ FuYouJ commented Aug 26, 2024

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -43,7 +43,7 @@ libfb303-xxx.jar
| data_save_mode | Enum | No | APPEND_DATA | The data save mode |
| paimon.table.primary-keys | String | No | - | Default comma-separated list of columns (primary key) that identify a row in tables.(Notice: The partition field needs to be included in the primary key fields) |
| paimon.table.partition-keys | String | No | - | Default comma-separated list of partition fields to use when creating tables. |
| paimon.table.write-props | Map | No | - | Properties passed through to paimon table initialization, [reference](https://paimon.apache.org/docs/0.8/maintenance/configurations/#coreoptions). |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link seems to be accessible

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link seems to be accessible

I found that this link will only keep the latest version. For example, when version 0.9 is released, it will overwrite 0.8.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your viewpoint

@FuYouJ FuYouJ requested a review from wuchunfu August 27, 2024 02:54
@Hisoka-X Hisoka-X changed the title fix paimon.apache.org deadlink [Improve][Document] Fix paimon.apache.org deadlink Aug 27, 2024
@liugddx liugddx merged commit c6f627f into apache:dev Aug 27, 2024
10 checks passed
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants