-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][Transforms-V2] Fix LLM transform can not parse boolean value type #7620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not change it in
?323c1a0
to
8d8a17f
Compare
LLM return [True], The JSON standard requires Boolean values to be lowercase true or false, not uppercase True or False. |
Got it |
...nsforms-v2-e2e-part-1/src/test/java/org/apache/seatunnel/e2e/transform/TestLLMBooleanIT.java
Outdated
Show resolved
Hide resolved
8d8a17f
to
8212565
Compare
8212565
to
b3846ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @hawk9821
Purpose of this pull request
issues: #7617
Does this PR introduce any user-facing change?
no
How was this patch tested?
TestLLMBooleanIT#testLLMWithOpenAI
Check list
New License Guide
release-note
.