Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][connector-v2]Support opengauss jdbc connnector using opengauss driver. #7622

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

luckyLJY
Copy link
Contributor

Use opengauss driver to implement opengauss jdbc sink and source

@dailai
Copy link
Contributor

dailai commented Sep 10, 2024

Good job. I often encounter authentication issues when using jdbc-pg to connect to opengauss. When the password_encryption_type=1 of the Opengauss database is used to encrypt the password in the sha256 mode, which is compatible with the MD5 authentication mode of the postgres client, but when password_encryption_type=2 means that the password is encrypted using sha256, which is not compatible with the postgres driver . The postgres driver gives an error,
1

@luckyLJY luckyLJY force-pushed the submit branch 3 times, most recently from f0c21bb to 62a9b84 Compare September 19, 2024 02:00
@dailai
Copy link
Contributor

dailai commented Oct 12, 2024

This implementation code is almost identical to jdbc-postgresql, so I suggest you just rely on jdbc-postgresql's implementation and override only the implementation of specific methods, such as those involving jdbc-url and the drivers in the pom.

@luckyLJY
Copy link
Contributor Author

This implementation code is almost identical to jdbc-postgresql, so I suggest you just rely on jdbc-postgresql's implementation and override only the implementation of specific methods, such as those involving jdbc-url and the drivers in the pom.

Make changes to the code as suggested.

Copy link
Contributor

@dailai dailai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passed

…uss driver.

获取最新代码

获取最新代码

获取最新代码

[Feature][connector-v2]Support opengauss jdbc connnector using opengauss driver.
@dailai dailai requested review from Hisoka-X and removed request for hawk9821 October 16, 2024 08:58
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luckyLJY !

@Hisoka-X
Copy link
Member

@hawk9821 would you mind take a look again?

Copy link
Contributor

@hawk9821 hawk9821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . thanks @luckyLJY

@Hisoka-X Hisoka-X merged commit bbf6437 into apache:dev Oct 16, 2024
7 checks passed
@luckyLJY luckyLJY deleted the submit branch October 21, 2024 02:09
fcb-xiaobo pushed a commit to fcb-xiaobo/seatunnel that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants