Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] [Connector-V2] Optimize milvus-connector config code #7658

Merged
merged 2 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.seatunnel.connectors.seatunnel.milvus.config;

import org.apache.seatunnel.api.configuration.Option;
import org.apache.seatunnel.api.configuration.Options;

public abstract class MilvusCommonConfig {

public static final String CONNECTOR_IDENTITY = "Milvus";

public static final Option<String> URL =
Options.key("url")
.stringType()
.noDefaultValue()
.withDescription("Milvus public endpoint");

public static final Option<String> TOKEN =
Options.key("token")
.stringType()
.noDefaultValue()
.withDescription("Milvus token for authentication");
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,21 +28,7 @@
import static org.apache.seatunnel.api.sink.DataSaveMode.DROP_DATA;
import static org.apache.seatunnel.api.sink.DataSaveMode.ERROR_WHEN_DATA_EXISTS;

public class MilvusSinkConfig {

public static final String CONNECTOR_IDENTITY = "Milvus";

public static final Option<String> URL =
Options.key("url")
.stringType()
.noDefaultValue()
.withDescription("Milvus public endpoint");

public static final Option<String> TOKEN =
Options.key("token")
.stringType()
.noDefaultValue()
.withDescription("Milvus token for authentication");
public class MilvusSinkConfig extends MilvusCommonConfig {

public static final Option<String> DATABASE =
Options.key("database").stringType().noDefaultValue().withDescription("database");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,7 @@
import org.apache.seatunnel.api.configuration.Option;
import org.apache.seatunnel.api.configuration.Options;

public class MilvusSourceConfig {

public static final Option<String> URL =
Options.key("url")
.stringType()
.noDefaultValue()
.withDescription("Milvus public endpoint");

public static final Option<String> TOKEN =
Options.key("token")
.stringType()
.noDefaultValue()
.withDescription("Milvus token for authentication");
public class MilvusSourceConfig extends MilvusCommonConfig {

public static final Option<String> DATABASE =
Options.key("database")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.apache.seatunnel.api.table.catalog.CatalogTable;
import org.apache.seatunnel.api.table.catalog.TablePath;
import org.apache.seatunnel.api.table.type.SeaTunnelRow;
import org.apache.seatunnel.connectors.seatunnel.milvus.config.MilvusSourceConfig;
import org.apache.seatunnel.connectors.seatunnel.milvus.convert.MilvusConvertUtils;

import java.util.ArrayList;
Expand Down Expand Up @@ -77,6 +78,6 @@ public SourceSplitEnumerator<MilvusSourceSplit, MilvusSourceState> restoreEnumer

@Override
public String getPluginName() {
return "Milvus";
return MilvusSourceConfig.CONNECTOR_IDENTITY;
}
}
Loading